ym-abaranov

Results 9 comments of ym-abaranov

> @ym-abaranov please see the lgtm induced alerts resolved

> @ym-abaranov Please update the description on the PR explaining what this new module does. @msm0504 done

Hi @Fawke, > Isn't there any way to avoid that? Actually, there is a way. Those functions are not exported in the consent management modules, so if you can export...

@Fawke, > Can you please route your ajax call through the in-built module apart from the other changes I suggested. Done > Isn't there a way for you to utilise...

@Fawke @dgirardi I don’t think that would work. In order to get consent data (uspDataHandler.getConsentData) it previously should be stored by consentManagement and consentManagementUsp. Those modules could be used and...

@dgirardi From my point of view exporting lookupIabConsent and lookupUspConsent might have an even smaller footprint though. Also, the handler interface and its interaction changes would work just fine for...

@dgirardi I'm not quite sure I'm using it right but looks like a promise is never resolved. Here are my steps: 1. Initializing consentManagment: ``` pbjs.que.push(function() { pbjs.setConfig({ consentManagement: {...

@dgirardi Here’s the test page — https://qa.yieldmo.com/temp/prebid-module-test/index.html So the duplicated methods from the adapterManager and adapterManagmentUsp: (lookupUspConsent and lookupIabConsent) are logging the data just fine. There are interfaces in the...

@dgirardi probably. I guess there is a chance that a publisher will use the module with no auction