ylemkimon comments

Results 60 comments of


                                            ylemkimon

conditional support in macros

- ~`\ifinner`~ - `\iftrue` - `\iffalse`

feat: add \htmlAttr command

I'm against adding `\htmlAttr` as (1) validation of attributes is impossible and (2) it may open to vulnerabilities and blacklisting is not enough.

feat: add \htmlAttr command

@junghoocho That seems to be OK. If you don't mind, could you update the PR? I'll leave #2265 open for discussions on allowing other attributes.

refactor: update toSplitInto to accept delimiters object

Thank you for the PR!

ci(screenshotter): use macos runner for Safari

The failing `Screenshotter / screenshotter (safari)` is the old screenshotter (Browserstack) and the `CI / screenshotter (safari)` is the new screenshotter (macOS runner).

ci(screenshotter): use macos runner for Safari

> With the current setup, I am able to generate Safari screenshots locally (by adding my Browserstack credentials to the environment), but relying on CI would prevent this (unless I...

Screenshotter can't do specific browser

`screenshotter.sh` doesn't support specifying the browser, but yes, it'd be useful.

feat(parser): add integer, dimen, glue group parsers

This incorporates changes from #2085, so it'd be preferable to review it first.

\sqrt\quad fails

Will be fixed by #2139. No timeline yet, sorry.

RFC: Add `preunpack` life cycle script

@Djay77 see https://github.com/npm/cli/issues/2660.