Ying comments

Results 62 comments of


                                            Ying

Add Complex Types support in Native Parquet Reader

I'm working on it

Fast bit unpacking

cc @Yuhta @oerling

Fast bit unpacking

@Yuhta @oerling @zzhao0 Can you please review this?

Fast bit unpacking

@Yuhta Jimmy I've addressed all comments, will you be able to take another look? Thank you.

Fast bit unpacking

@Yuhta Jimmy thanks for importing this PR. Could you tell me what the failures are on the facebook internal tests?

Fast bit unpacking

Closing in favor of https://github.com/facebookincubator/velox/pull/3000

Replace DuckDB Parquet writer to Arrow writer for ParquetTpchTest

cc @oerling @majetideepak

Replace DuckDB Parquet writer to Arrow writer for ParquetTpchTest

@majetideepak I actually made a mistake in describing the issue. There was no failure for this particular case and sorry for the confusion. This issue is mainly for ParquetTpchTest to...

SelectiveStructColumnReader::filterRowGroups() return duplicate RowGroup Ids

Related issue https://github.com/facebookincubator/velox/issues/2329 I'm working on a fix. Assigning to myself.

SelectiveStructColumnReader::filterRowGroups() return duplicate RowGroup Ids

This bug is DWRF only and does not affect the correctness. To fix it, it requires some refactoring and needs to be thought over. I will defer the fix to...