Yifan Yu
Yifan Yu
Sorry it's not a up-to-date implementation of our CBMR, I will update it soon!
@tsalo Thanks for creating the new repo! I will get myself familiar with integration tests these days and work on this issue :)
> @yifan0330 do you want to refactor CBMR here or in your CBMR repo? I have a few ideas about dependencies and documentation. I guess it would be easier and...
The statistical test in the negative direction only happens for one-sided left-tail test $p=P(T \leq t \vert H_0)$, for test-statistic $t$ from distribution $T$. In our case, I guess it...
> Thanks @yifan0330! could you add a test to the `test_z_to_p` function demonstrating the fix? add something like `(-1.959963, "one", 0.975)`, > > https://github.com/neurostuff/NiMARE/blob/13d7b196e95f481f2c6b9cda7411ced942075935/nimare/tests/test_transforms.py#L249-L264 Sorry I just saw your comments!...
> LGTM, thanks for all your hard work on this @yifan0330! this is an excellent contribution! Thanks for all your help and supervision @jdkent !! It has been a great...
> Also thanks to @tsalo and @adelavega for testing and offering reviews and having heated (but friendly) conversations about code structure. Thanks to @tsalo and @adelavega for useful suggestions and...
> @yifan0330 seemed to have a good handle on z-to-p conversion (and probably p-to-z conversion), given #748 and #749. @yifan0330 would you be willing to take a look at this?...
> @JulioAPeraza if @yifan0330 is happy with the changes then absolutely, I think it's good to merge. Yeah I am happy with Julio's changes :)
> just some spelling errors to fix for now! Sorry for the spelling errors! I've fixed them now