Mattias Öhrn

Results 28 comments of Mattias Öhrn

This is me again but using another account. I'll be using this from now on.

Hey, so I finally got around to looking at this. Unfortunately, I'm struggeling to find the time at the moment. I have got it working for the basic `ImmutableMap` cases...

@agudian: 1. My thinking there was that one of the use cases for `@MappingTarget` is that you might want to be able to pass in a subclass instance. 2. The...

Thinking a bit more about this I believe that not supporting the features I brought up make sense from the perspective of being able to be consistent with what can...

@filiphr, I haven't looked at `StreamMappingMethod.ftl`, I'll do that as soon as I get the chance. Meanwhile, there is one thing in your answer that confuses me. Why wouldn't `@BeforeMapping`...

Hi and thanks for the response! 1. Cool, I should definitely be able to create a PR for this. Just want to discuss the next one a bit more first....

Great, and no stress - it's not like these suggestions are critical. Just wanted to get rid of some more boilerplate. I'll try to get to this later this week.

@petergtz would you consider releasing a new version now? At that point I think we could close this one. We can discuss the Gomega matcher integration separately but I have...

Actually, thinking a bit more about custom matchers I feel that this could be simplified further so I created #114. Let me know what you think.

I agree, I'd rather wait for the other PR to be merged first.