YH

Results 13 comments of YH

``` sort all imports (python)................................................Failed - hook id: isort - files were modified by this hook Fixing /fsx/home-yhna/test/ColossalAI/colossalai/zero/sharded_optim/sharded_optim_v2.py yapf formatter...........................................................Passed clang formatter......................................(no files to check)Skipped check yaml...........................................(no files to check)Skipped...

> Thank you for your contribution. Your PR message and docstring helped me understand your design. Before we delve into implementation details, let's consider the relationship between the `runner` and...

> Thank you for your contribution! I believe the current solution is reasonable. However, I'm curious if it's possible to integrate the process of calling `from_tuning` into the `Runner.train` and...

> I'm very sorry for the delayed response. I think your considerations are very reasonable. MMEngine introduced `FlexibleRunner` in v0.8.0, which can fully lazy-initiate various components, and it should be...

Thank you for the review! I understand the concern regarding the PyTorch version support. Since Zach's input is pending, I'm happy to wait for his review. However, I would like...

> Do you know what that version would be? If not, we could just try 2.0. Regardless though, this PR would need to wait for Zach's approval to be merged,...

Thank you for getting back to me, and I hope you had a wonderful holiday! For this PR, I suggest merging it as it corrects the issue with the `pytorch-version`...

> ```diff > - if [[ ${{ matrix.pytorch-version }} = minimum ]]; then pip install torch==1.10.0; fi > + if [[ ${{ matrix.pytorch-version }} = minimum ]]; then pip install...

> Hi @yhna940 thanks for the contribution! Could you add the same description you added to the PR to serve/docker/README.md and also add a line referring to that section into...

Hello @mreso, I hope you're doing well! I wanted to follow up on the status of this PR. Are there any additional changes or updates you'd like me to make?...