Yueh-Hsuan Chiang
Yueh-Hsuan Chiang
@siying The Linter says there's one warning internally at Meta. Do you happen to know what it might be? https://github.com/facebook/rocksdb/pull/10348/checks?check_run_id=8882167321 ``` 1 warning internally at Meta. ```
* Addressed @jay-zhuang's comment. * Improved HISTORY.md to further describe how the FIFO migration works.
Same CI error here. Will rebase once the PR has been fully reviewed. ``` + cargo audit --ignore RUSTSEC-2020-0071 --ignore RUSTSEC-2023-0001 --ignore RUSTSEC-2022-0093 -- | Fetching advisory database from `https://github.com/RustSec/advisory-db.git` ...
Making this PR draft again as the thread-safety part has been move to a dedicate PR https://github.com/solana-labs/solana/pull/35143
I think here're the problems this PR tries to solve: (a) Having one same error type represents this file isn't a TieredStorageFile. (b) Having a fixed same tailing bytes at...
> > If we want to check it outside of the new_rom_footer_block(), then we are likely to pay one more seek. > Gotcha, this makes sense. How expensive is seek?...
Looks like the only place it is used is in the store-tool, but it can be replaced by the AccountsFile API: ``` error[E0599]: no method named `account_iter` found for struct...
> Looks like this PR was marked as a draft right around when I was added as a reviewer. Do you want me to review now? If yes, can the...
Just undo one change that should belong to a different PR via `git push -f`. Hope it doesn't clear your review history.