Yueh-Hsuan Chiang

Results 55 comments of Yueh-Hsuan Chiang

Thanks for raising the issue. I will take a deeper look. I happen to have one node that enables RocksDB perf metrics that might provide some relevant information. When `get_slots_since`...

Looks like we are issuing [multiple get operations sequentially](https://github.com/yhchiang-sol/solana/blob/master/ledger/src/blockstore.rs#L2962-L2963) in `get_slots_since()`. One possible way to improve it is to use RocksDB's [batch-version MultiGet API](https://github.com/facebook/rocksdb/blob/main/include/rocksdb/db.h#L631-L654), but RocksDB's C and rust API...

Created https://github.com/facebook/rocksdb/pull/9952 that makes the batch-version MultiGet API available in RocksDB's C API.

The PR for rust-rocksdb: https://github.com/rust-rocksdb/rust-rocksdb/pull/633

> So, the optimization of get_slots_since() is good, but we could potentially realize even larger savings by being smarter about avoiding repeated queries. Look like a good opportunity here! RocksDB's...

I will be traveling within 24 hours so might not have time to take a deeper look, but I will do my best! > Re: https://github.com/solana-labs/solana/issues/25941 that is super interesting....

> Just enabled apport to capture the core dump. It is only a matter of time before it happens again and can provide you with a core dump. @codemonkey6969 do...

> Here is the rocksdb log file: https://snapshots.nodemonkey.io/snapshots/LOG.txt I checked the above rocksdb log file, but there isn't anything abnormal. @codemonkey6969: can I know whether this is the one that...

> Cannot create a core dump. It is not triggering one. I want to reiterate how impactful this issue is to my RPC service. Every time it receives high traffic,...

@codemonkey6969: Thanks for confirming the PR resolved the issue.