Yueh-Hsuan Chiang

> Trying to understand the logic here. With the change, do we still compact all files to L0. In which case we place files in non-L0? So FIFO still only...

Rebased and resolved initial comments.

Created https://github.com/facebook/rocksdb/pull/10726 on top of this PR that further improves the CompactionPicker logic for FIFO on non-L0 levels so that it will use the file creation time to pick the...

Hello @siying, @ajkr. I've updated the PR and created https://github.com/facebook/rocksdb/pull/10726 which improves the multi-level FIFO further. You can view this one as the base support and view https://github.com/facebook/rocksdb/pull/10726 as the...

Thanks for the feedback, @siying. I think your understanding is correct. > It looks like that files will be first pushed to deeper levels, and then up to L0. FIFO...

@siying, @jay-zhuang: Thanks for the discussion via VC. Here's the summary: * Update the code comment mentioning the compaction picker logic for FIFO on non-L0 files are only for migration....

* Rebase. * Update FIFOCompactionPicker::PickSizeCompaction to pick the left-most files in non-L0 case. * Update FIFOCompactionPicker::PickCompactionToWarm to skip when there're non-L0 files. * Update the test case to verify the...

@siying: I am not able to reproduce the error locally. Does the following error message indicate hang or time out? Do you happen to have any additional logs available internally?...

> Yes I think it indicates hanging. I don't know how CircleCI permission is managed. Are you able to rerun a test with "Rerun Job with SSH" option? In that...

Thanks for the stack-trace, @siying! Originally I was wondering whether it is the case that the test is waiting for compaction but the compaction has already finished so the test...