Yassine Guedidi

Results 120 comments of Yassine Guedidi

@EINDEX looking at `\Wallabag\Controller\Api\EntryRestController::retrieveValueFromRequest()` it clearly uses `$request->request->get(`, that is the equivalent for `$_POST`, so for normal post submissions, not JSON ones đŸ˜•

Maybe @j0k3r @nicosomb @Kdecherf know better than be about API documentation?

Hey hey Grégoire! I'm fine, hope the same for you! > Are you sure that at runtime, you ever end up with a `Type` instance being passed to `setParameter`? I'm...

> Is there a reason not to do it at the AbstractQuery level? Any reason I can think of :) I can try a PR if you want? which branch...

@ronanguilloux anything I could do to have this accepted?

@Kdecherf nice idea, but to me deserves its own PR, so we can do the specifications on how best to implement it. better to keep this PR scoped to the...

@j0k3r would you accept this in 2.x? so that it can be added to wallabag quickly. if, will add tests to finalize the PR

@j0k3r no, the concept of config files remains, but inside builtin implementation of ConfigLinesProvider. generally idea is to abstract this line from ConfigBuilder: https://github.com/j0k3r/graby/pull/370/files#diff-57ddfd00eaf8ee57ae09810c0bbe77bdd6a674e8b02363e9317520333be61df2L266 did that this way to be...

will do my best to finalize this this week!

@j0k3r question for you: should I limit this PR in graby just to the interface and the default implementation only, and have the rest in wallabag? Or should I include...