Yassine Guedidi
Yassine Guedidi
My initial intent with dedicated functions is to enforce to pass the label to follow accessibility best practices when using an icon in an informative/functional purpose. That's why I went...
I agree with all your points! Just one thing, the proposed support for accessibility is not on Twig, that is indeed low-level, but on UX Icons, and I believe accessibility...
thanks @kbond! @smnandre do you want to build your solution or can I give it a try (I never contributed PRs to Symfony UX yet 😅)
@kukulich is the addition of the label means the idea is accepted? if yes I can try to come with a PR :)
> do we need to write some documentation? @nicosomb I don't think so, or at least I don't see what could be documented in this change
@nicosomb first sorry for not being that available lately for wallabag... I think it's worth doing a rebase just in case, also extract few change to facilitate review, and also...
@nicosomb had a bit of time during lunch break so I checked again the diff, and maybe the move to env variables may be an issue for users upgrading wallabag,...
@j0k3r @Kdecherf any opinion on is the switch to env vars an issue for a minor/patch release?
At least regarding the fact that it's not styled, it's because now assets (CSS and JS) are not in the git repository anymore. Easiest way to solve this would be...
@j0k3r @nicosomb @Kdecherf could you please have a look on the approach here? As we use migrations I made it a migration :) I tried to also have a down...