Yves Goergen

Results 295 comments of Yves Goergen

I'm wondering why this download is necessary at all. Can't that file be included in the app package? It's not like it's huge. Are there licensing issues? Does it have...

Hm, I'm not so sure about the https download: https://github.com/BasicAirData/GPSLogger/blob/master/app/src/main/java/eu/basicairdata/graziano/gpslogger/FragmentSettings.java#L156 The page you linked above does not contain any licence or terms of use. It's just a disclaimer that says...

That redirection is unfortunately insecure. You rely on the server to redirect you to https (and even the same requested resource). But since this is all happening unencryptedly, an attacker...

Ah, that explanation helps. A good place for that would be the code itself. Just a short comment reasoning this insecure approach. At least from a code reviewer's perspective, that...

That's a good addition. The app I used before had that, too. Here's how I would do it: Keep it simple. Only make a single user setting, not more buttons...

No I don't have an example that shows a difference. I'm not using the PHP DOMDocument. I've written something else to reduce whitespace in text nodes now. And it can...

https://gist.github.com/ygoe/065aceb90f9efd81e8f57ee01546b5f7 The code shows how I minify HTML manually. It may not be 100% safe but has worked for me so far. And it still leaves single spaces in places...

Maybe the same bug here. Sometimes the packages can be restored, sometimes they cannot be resolved by "unpkg". I've read that unpkg is way better than cdnjs because of its...

Oh, maybe it has to fetch on every build because of #490. It doesn't know what it's doing or what it has done. So it has to check every time....

@nickalbrecht jsDelivr is not available in the selection. How did you do that?