Yuliana Apaza

Using ctx.commandFailed with a subclass of TransportException breaks test

6

Current state: - AuctionEntity - Throws subclass of `TransportException`: [`BidValidationException`](https://github.com/lagom/online-auction-java/blob/master/bidding-impl/src/main/java/com/example/auction/bidding/impl/AuctionEntity.java#L177) which doesn't implement `equals` and `hashCode` [Test](https://github.com/lagom/online-auction-java/blob/master/bidding-impl/src/test/java/com/example/auction/bidding/impl/AuctionEntityTest.java#L195) is passing - PItemEntity - Use `ctx.commandFailed` with [`UpdateFailureException`](https://github.com/lagom/online-auction-java/blob/master/item-impl/src/main/java/com/example/auction/item/impl/PItemEntity.java#L77) which isn't a subclass...

Naming convention for private representations of -api projects

3

Currently, the private copy for a class of API project is PXyz (like `PItem`, `PItemState`, etc) or sometimes it's the exact same name with only a package difference. We should...

Move CassandraReadSideUtils and CompletionStageUtils to core

11

``` ./item-impl/src/main/java/com/example/auction/item/impl/CassandraReadSideUtils.java:11: // TODO: move to core? ./tools/src/main/java/com/example/core/CompletionStageUtils.java:14: // TODO: move to core? ``` Move CassandraReadSideUtils (item-impl) and CompetionStageUtils (tools) into the core Lagom framework

Update CreateItem command

1

``` ./item-impl/src/main/java/com/example/auction/item/impl/ItemServiceImpl.java:82: // TODO: remove this PItem from here and pass the 3 values in the command? ./item-impl/src/main/java/com/example/auction/item/impl/PItemCommand.java:23: // TODO: change payload of this command. ``` PItemCommand.CreateItem (item-impl) should take...

``` ./item-impl/src/main/java/com/example/auction/item/impl/ItemServiceImpl.java:53: // TODO: doc this. ``` Write doc comments for the Javadoc in item-impl: ItemServiceImpl#handleBidEvent. Also complete the doc comments for this services API (following the example in bidding-api...