Ryan
Ryan
> 看下 visual diff 好的
> 看下 visual diff @afc163 想问下我本地分支改了样式后,没有和visual diff这么大的差距是为什么呀,本地看上去挺正常的。
感觉分支出了问题了,本地run test 和 test:image没报错,但是提交上来跑action失败了
> > 感觉分支出了问题了,本地run test 和 test:image没报错,但是提交上来跑action失败了 > > 是的,nwsapi 升级导致 单测那边 jsdom 出了点问题,先锁一下版本。 下次有这种问题可以发群里,大家响应的快一点,很快就有人来修了~ > > 现在好了~~ #53045 ok, 不过我还没加群也,能给个二维码么 ~
> image diff 不对劲 我改动了一部分的css属性,new tag的那些图片本地上看没差那么多,把span元素改成button后想和原来保持完全一样的布局感觉不太好实现
这个issue 分配给我吧 我来处理
> ### What problem does this feature solve? > `removeIcon` in the `Upload` component is visible only on hover. However, on mobile devices where hover is not available, it becomes...
> > ### What problem does this feature solve? > > `removeIcon` in the `Upload` component is visible only on hover. However, on mobile devices where hover is not available,...
> Why do we need a prop to show the Remove Icon? Can we disable the hover effect to show the icon if the screen size equals mobile width? This...
位置变化的监听要用到rFA或者setTimeout, 感觉性能损耗程度会比功能需求程度高很多