Yeikel

RSPEC-2095: Resources should be closed

2

> Connections, streams, files, and other classes that implement the Closeable interface or its super-interface, AutoCloseable, needs to be closed after use. Further, that close call must be made in...

See https://rules.sonarsource.com/java/RSPEC-2168

https://rules.sonarsource.com/java/type/Bug/RSPEC-3655 See as well : https://github.com/openrewrite/rewrite-static-analysis/issues/58

RSPEC-1941: Variables should not be declared before they are relevant

1

See https://rules.sonarsource.com/java/RSPEC-1941

> While the ternary operator is pleasingly compact, its use can make code more difficult to read. It should therefore be avoided in favor of the more verbose if/else structure....

Replace multiple concatenation with .append calls

1

```java StringBuilder output = new StringBuilder(); var elements = List.of("A","B","C"); for (var i : elements){ output.append("A" + i); } ``` ```java StringBuilder output = new StringBuilder(); var elements = List.of("A","B","C");...

Before: ```java boolean isUser = x != null && x instanceof User; boolean isNotUser = y == null || !(y instanceof User); if(x != null && x instanceof User) {...

Use dedicated Optionals for primitives

1

```java Optional longValue; Optional number; Optional doubleOtional; ``` ```java OptionalLong longValue; OptionalInt number; OptionalDouble doubleOtional; ``` Relevant : https://stackoverflow.com/questions/33190768/optionalint-vs-optionalinteger

Rule: S2325 Methods that don't access instance data should be static

3

See https://jira.sonarsource.com/browse/SONARJAVA-1018

```java Map map = new HashMap(); map.put("hello","world"); for (String key : map.keySet()){ String value = map.get(key); System.out.println("Key " + key + " value " + value); } ``` ```java Map...