Yeikel

Hamcrest to JUnit Jupiter migration recipes

5

While the Hamcrest repo is still [active](https://github.com/hamcrest/JavaHamcrest/commits/master), the latest release is from [Oct 16, 2019 ](https://github.com/hamcrest/JavaHamcrest/tags) I think that this is a potential good use case for a migration recipe...

https://junit.org/junit5/docs/current/user-guide/#dependency-metadata-junit-bom

Transform assertTrue to assertSame or assertNotSame

2

```java org.junit.jupiter.api.Assertions.assertTrue(a == b); org.junit.jupiter.api.Assertions.assertSame(a,b); org.junit.jupiter.api.Assertions.assertTrue(a != b); org.junit.jupiter.api.Assertions.assertNotSame(a, b); ```

Remove `@VisibleForTesting` if variable is accessed from production code

3

Leaving the `VisibleForTesting` is misleading in this scenario Similar SPEC : [RSPEC-5803](https://jira.sonarsource.com/browse/RSPEC-5803)

Leaving the VisibleForTesting is misleading in this scenario Similar SPEC : [RSPEC-5803](https://jira.sonarsource.com/browse/RSPEC-5803) Similar issue https://github.com/openrewrite/rewrite-testing-frameworks/issues/224

Remove junit-vintage-engine with the recipe JUnit4to5Migration

4

Given the following dependency : ``` org.junit.vintage junit-vintage-engine test ``` And recipes : ``` org.openrewrite.java.testing.junit5.JUnit5BestPractices org.openrewrite.java.testing.junit5.JUnit4to5Migration ``` Rewrite creates the following change : ``` org.junit.vintage junit-vintage-engine test junit junit ```...

When this happens, it is a likely a user error(IDE importing the wrong classes) Example : [`Assert.assertNotNull`](https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/Assert.java)

Exclude Junit 4 indefinitely using maven-enforcer-plugin

2

Running `JUnit4to5Migration` does not guarantee that in the future team members will not include Junit4 to the classpath accidently (IDEs are the main one to do so) In my team,...

Use Parameterized Tests. RSPEC-5976

1

Is this something that could be achieved with this framework? > When multiple tests differ only by a few hardcoded values they should be refactored as a single "parameterized" test....

Recipe to migrate from system-rules to system-stubs

1

See : https://github.com/stefanbirkner/system-rules/issues/55 Sample changes : Remove ```java import org.junit.Rule; import org.junit.contrib.java.lang.system.EnvironmentVariables; @Rule public final EnvironmentVariables envVars = new EnvironmentVariables(); ``` Remove the dependency : ```xml com.github.stefanbirkner system-rules test ```...