Ye Luo

@jtkrogel the changes is PR is still crucial to keep minimal code with mixed precision support. I will follow up on this PR once @PDoakORNL finishes the dependent estimator.

Since estimators are re-implemented from scratch, I feel it is chance to revisit and probably minimizing supported features. @prckent yes. When reviewing #5212, I feel the need to understand what...

I guess that was introduced to minimize a needed implementation for a new SPOSet. It is maybe needed for some functions but definitely not for makeClone. I'd like to restrict...

With clang, `-DCMAKE_BUILD_TYPE=Debug` doesn't add optimization flags `-Ox` namely using the default `-O0`. I can reproduce the issue and after adding `-O3` using `-DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS=-O3`, the error disappears. So it...

> Any chance for a small reproducer? Can you make an issue on the relevant repo and link it here? Unfortunately, it will be very very low priority for me.

It is a MPC bug like https://github.com/QMCPACK/qmcpack/issues/4725. Clearly there is unsafe code. Let me see if I can find the cause.

Thinking of how to avoid adding new files. Can we make `SPOSetT` as an actual shim layer derived from SPOSet. Once a derived class is ported. It changes base from...

> @ye-luo thanks for chiming in. We just thought having a separate SPOSetT hierarchy would help us with CI (at least build errors we introduce are caught) and for us...

We learned from this PR that a top-down approach isn't friendly to developers. The idea has been picked up using bottom-up approach instead. See https://github.com/QMCPACK/qmcpack/pulls?q=is%3Apr+sposet+template+is%3Aclosed This PR can be closed.

Are you sure "mpiicc" and "mpiicpc" are GCC? They seem to be intel classic compiler. gcc 11.4 + MKL seems happy on my laptop. I guess that is an issue...