Ye Luo
#3065 keeps doing in the wrong way.
This recompute option doesn't call the evaluateLog directly. It is implemented depending on the WFComponent. Currently only SD adds the extra operation of recomputing Orbitials and slaterdet inverse. No recomputing...
In the past, not recomputing helped me finding more bugs. The recomputing often hide bugs. I also didn't get a single solid data point that recomputing is necessary. If someone...
Recomputing does add cost and fortunately it is not heavy. It should be clear that we do recomputing because this is the only way to stop the error accumulated in...
I would suggest this input option being contained in the "estimators" node instead of being exposed directly in the DMC input section and then its name can be cut short...
I'm thinking of always requiring a driver scope `estimators` node to activate the global estimators. This rule allows us to disable the global estimators in places where we don't need...
@rcclay I had a hard time locating the per walker clone of `ions` and I'm wondering if the removed finite difference code actually worked properly in threaded runs. Do you...
> It's going to be a bunch of work for me to unwrap all my dependent changes from my fix and encapsulation of kcontainer. Just finish your review of my...
I don't have any PR prepared to address this issue which is mostly a TODO list I have in mind. A few of them was discussed when the finite difference...
> I do not support this reversion. This PR is left pending as it was. Will revise and clean up once your estimates get in.