Shaunak Kashyap

Results 63 comments of Shaunak Kashyap

👋 @dlvhdr and @maaslalani, I took a stab at implementing this feature request here: https://github.com/maaslalani/slides/pull/192. Please take a look and let me know what you think. Thanks!

Perhaps we should revert https://github.com/open-telemetry/opentelemetry-collector/pull/9257 and reopen https://github.com/open-telemetry/opentelemetry-collector/issues/8007 for now, so we can take another stab at implementing validation in a different way?

I'm unable to simply click the "Revert" button on https://github.com/open-telemetry/opentelemetry-collector/pull/9257 so instead I've created https://github.com/open-telemetry/opentelemetry-collector/pull/10078 manually reverting the relevant bits of that PR.

PR is still active; waiting on review.

Hi @bogdandrutu, would you mind kicking off the CI checks again on this PR, please? Thanks!

Thanks @atoulme, for kicking off CI again. I've fixed another linter error (from `impi`) in https://github.com/open-telemetry/opentelemetry-collector/pull/9257/commits/8b53d4ea9d24e6d5cc19b73fa1d971573112b7a0. Would you mind kicking off CI one more time, please? Thank you. BTW, I...

> It's possible contrib CI is broken. Rerunning. Thanks. ~Or could it be because I'm not a OTel Community member (yet)?~ [EDIT] Never mind, I misunderstood what you meant by...

Hi @atoulme, could you please guide me on what's needed to merge this PR? I'm afraid it will be closed in 14 days otherwise due to being stale. Thanks!

> you ask for review by pinging approvers. Pinging @Aneurysm9, @djaglowski, @jpkrohling for review. Thanks!

Hi @djaglowski, @bogdandrutu, @sfc-gh-bdrutu, is there any more work needed on this PR? Thanks!