Yushin Cho

Results 22 comments of Yushin Cho

Sure, rav1e always can encode losslessly. I believe AV1 do that with only using 4x4 DCTs as transform, correct?

Also commented from: https://github.com/xiph/rav1e/pull/482#issuecomment-414481070 One possible (easier) way to resolve this issue would be to decouple the nested RDO loops of luma and chroma intra modes as in libaom. Meanwhile,...

Yes, I agree that rav1e needs this better way of handling input frames to it and output bitstream from it asynchronously. Thank you for pointing this out!

Please check my relevant comment at https://github.com/xiph/rav1e/pull/1485#issuecomment-540082355 I probably should have stated this earlier, I think the activity based RDO would not help yielding PSNR gains by its nature but...

> Instead of just DC, try all of them and use the minimal intra-cost. > > [AWCY on `--speed 2`](https://beta.arewecompressedyet.com/?job=speed2-2019-09-06_163944-f39b1d7&job=all-intra-modes-importance-speed2-f0.9-a0.8-2019-09-09_230607-e01baca) shows good PSNR improvement. > Since its impact on enc...

> OK, I see what's happening. The logic behind my 'cost always goes down' invariant is incorrect. *_* Okay, I haven't seen this. Nice catch, @tmatth!

> > @tmatth is this ready to land? > > No still a WIP. Why? Still weird?!

I might have seen this PR, but was not able to recall this much progress is already there. I hope we want not to waste this PR and land of...