Yonel Ceruto
Yonel Ceruto
@stof I see your point. That brings me back to the current proposal of a separate method that enables this validation, no matter how/where the parameter is defined. I'm open...
I updated the proposal terminology from "require" to "non-empty". Hopefully it's clearer now.
@symfony/mergers any objection to move forward in this direction? more [changes in PhpDumper](https://github.com/symfony/symfony/pull/57611#discussion_r1661832710) are coming...
>LGTM, what about the TODO note? will be addressed in this same PR >I'm also wondering about what we consider empty? PHP has an empty() "function" that encompasses false, 0,...
This is ready for final review. Note that some changes in `PhpDumper` impact unrelated fixtures when non-empty parameters aren't tested.
Hey @nicolas-grekas, just a friendly ping to see if there’s anything else needed here?
Comments addressed (Windows failures look unrelated).
Agreed! I've updated it to consider only `null`, `''`, and `[]` as empty parameter values.
After reconsidering, I don’t see `false` or `0` as empty values within their respective data types. For instance, a container parameter used as a toggle to enable or disable a...