Masafumi Koba

Results 705 comments of Masafumi Koba

Got it. Let's wait for other member's feedback.

There seem no objections, so let's transition to "ready to implement". Rule URLs are used only by a few formatters (for reporting). We can change the logic. E.g. https://github.com/stylelint/stylelint/blob/5e2eff74a474af5fb0bdfd4c678f3e17bb758935/lib/formatters/verboseFormatter.mjs#L142-L148 ```js...

@emmacharp Can you share your branch?

Ah, I understand my explanation is not enough. 😅 Probably, we may have to save `url` properties in secondary options like `message` or `severity` properties. https://github.com/stylelint/stylelint/blob/a5965a09b557fd4a5420a6b48f1c1353ecf83aa2/lib/lintPostcssResult.mjs#L102-L105 Users cannot change a...

@emmacharp Ah, I understand what you mean in the questions above. When a formatter function is called, lint results are not yet set to `returnValue.results`. See the code: https://github.com/stylelint/stylelint/blob/a5965a09b557fd4a5420a6b48f1c1353ecf83aa2/lib/prepareReturnValue.mjs#L67-L69 I...

@emmacharp The commit looks good. Can you open a PR if you're ready? Rather than the `message` property, adding a new `url` property to the `Warning` object is better. E.g....

@emmacharp You can set `url` to `warningProperties` as `customMessages`: https://github.com/stylelint/stylelint/blob/a5965a09b557fd4a5420a6b48f1c1353ecf83aa2/lib/utils/report.mjs#L119-L125

> I think an exploratory review of all the rules is a preliminary to the deprecation. Good point. Agree with this idea.

When I walk through all the rules quickly, the following rules seem to be related to non-standard syntaxes like SCSS: Affected by a rule itself: - [`no-invalid-double-slash-comments`](https://github.com/stylelint/stylelint/tree/eebb78694ee87e76245414108b0ae2626c78729f/lib/rules/no-invalid-double-slash-comments) see https://github.com/stylelint/stylelint/issues/7482#issuecomment-1902711979 Affected...

Extending such rules in 3rd-parties (e.g. `stylelint-scss`) might be very tough... 😓