Masafumi Koba
Masafumi Koba
Consideration about `rule.selector` performance makes sense. 👍🏼
@kaorun343 Thanks for the proposal. This idea sounds good to me. 👍🏼 Currently, we have a benchmark script using the [`benchmark`](https://www.npmjs.com/package/benchmark) package (see also our [document](https://stylelint.io/developer-guide/rules#improve-the-performance-of-a-rule)): https://github.com/stylelint/stylelint/blob/81f0b7fd3070f715627d9cbd4efb428b0bb206ee/scripts/benchmark-rule.mjs#L4 I'm against adding...
@fpetrakov We don't use any environment variables (`process.env`) except for the test use (`process.env.NODE_ENV === 'test'`). So, I guess we can implement `process.env.TIMING` with another module file like ESLint.
@yoyo837 Thanks for the report with the reproducible example. I can confirm the error with [this minimal reproducible demo](https://stylelint.io/demo/#N4Igxg9gJgpiBcIA8BDABAZwC4E8A2MAvADogC0ZGA7gJYAOMZAFjDQOZNbxoCMADHwCkpAHzEAdkgD0KMeJAAaEADMaBAHIoAtnEQwAHtroEAdJy15F4CONVsEIYBLRpSYAK7YIWgMo5xWCj6pNykdBDYYBgYzFgWpArOriAATu4EGCFoTuIuLm6eWN5kdCkQDCm4ZDBadFV4NOKMAEYwyhApMFmkKHhUKDiZIEkAvhIjVpC27ABiHVooWA4AVhg2VrB0GA45+SDY+DANAd0geIsw2AlJYRFYUTHmeKfnWJdYpOMgI0A): ```html ``` ```json { "customSyntax": "postcss-html", "rules": { "custom-property-empty-line-before": "always" }...
@yoyo837 Does [this case in a demo](https://stylelint.io/demo/#N4Igxg9gJgpiBcIA8BnALgTwDYwHwB0A7AAmIENjgjTSBaWlAdwEsAHGWgCxmYHNO08YgEYADKICkAbmrEAvkSQB6dNjxEQAGhAAzZjgByZALZxEMAB4nWOAHQA3AK5xtkQnt4IQVEsXwhLNBhCKBR-IQBtWVJ-VRwsZkI0WjcPBjQyELIAJyh-TWi-EDiYBKSUiHc+WmyYSGNTEJgoWicYf1kAXSI5LXBKjwAxCGzjMjQvACsUSr7YVhQvHxjizHjEtHCirHGYdHzZWLXSjYqq3nTMqBy8hG3d-a1D1bUy5NTq2vrG2Ba2rf8OyCjwKvn8rAg6DAKBQXDQxiwAJAQL2mxAPRAciAA) match a `.vue` case that you mentioned?
@yoyo837 Handling the two cases you provided seems difficult to me. 🤔 ```vue 123 a { // Should report `custom-property-empty-line-before` if there is no empty line --swipe-height: 100%; } ```...
I think this is not a bug of Stylelint because `postcss-html` produces the following AST: ```console $ node -e 'require("postcss-html").parse(`123`).walkDecls(console.log)' Declaration { raws: { before: '', between: ': ' },...
We can see minimal reproduction with [this demo](https://stylelint.io/demo/#N4Igxg9gJgpiBcIA8BDABAZwC4E8A2MAvADogC0ZAZhBPGgIwwC2A3KQHxID0K7IANCEoBLAgDkUTOIhgAPSQAcCAOgAWWJngHgIAOxEBzBCGDFdaNKTlYYuqBlJ0A2mYsXS2fDDzDdWMpD6wgZk2Ch2KABOUKSuaAC6-HGkYACu2BBMAMo4fiiyjpYgChDYYBgYZOqasboAvtqBhgBiEJFMKFjGAFYYetqwChjGpuZFngQ+foWkeJ0w2KRJYx64k77+TcGhWOFQUTEIRXM2iwLJxaVY5ZXVeDMgJwtYtQ11QA) using `postcss-html`. Also, I find a workaround to fix this problem: ```diff --- a/lib/rules/custom-property-empty-line-before/index.js +++ b/lib/rules/custom-property-empty-line-before/index.js @@ -78,7 +78,7 @@ const rule...
Ideally, I don't think Stylelint's built-in rules should fix the problem due to an HTML inline `style` syntax, because the built-in rules focus on standard CSS syntax. A workaround like...
> Maybe we can do something like #4726, Is this the same as what you said? No. `isFirstNodeOfRoot()` cannot fix this problem. The util can fix: ```html ``` but it...