Aditya Garud
Aditya Garud
hey @gadicc , working on this one.
hey @dtslvr i have already started working on this, do i give it a shot or leave it up to pahari?
#2189 is ready for review.
@binary-koan Is this the right move here, or is there an existing pattern I missed?
> In the screenshot, the X-axis dates (e.g. `Feb 2023`) for the two charts are not vertically synchronized. This needs to be fixed so the user can compare the data...
> > is this okay? > > I'm seeing something slightly different from the final goal. Can you compare this against the mockup of #3998 one more time? Added bounds:...
@ershad thanks for the review, Updated both tests to use fixed expected URLs can you check again ?
@ershad Sorry about the force push, I had to rebase to resolve app/helpers/products_helper.rb, and both review comments (keeping the Gumroad canonical check and hardcoding the custom-domain URL) are now addressed.
@EmCousin Friendly ping , since this is a quick fix
@EmCousin or @ershad could anyone please review this?