Adopt openfigi library for type-safety
The goal of this issue is to replace our custom implementation in the OpenFigiDataEnhancerService with the recently published type-safe library @gadicc/openfigi.
Hey all, author of the above here š
This should be quite an easy transition but feel free to tag me here on or the library's repo for any issues you experience š
The package is quite new but all the basics are working great and the TypeScript DX is pretty good. Anything you feel is missing or could be better for this use case, just let me know.
@dtslvr Hi!
Iām interested in contributing to this issue as part of Hacktoberfest. I see that the task is to adopt the @gadicc/openfigi library for type-safety in the OpenFigiDataEnhancerService. I want to make sure I understand the intended approach before starting.
Should the new library completely replace the current implementation, or should it coexist with the existing code for now?
Thanks! Iād love to make sure I follow the right approach before starting a PR.
hey @gadicc , working on this one.
Iām interested in contributing to this issue as part of Hacktoberfest.
Should the new library completely replace the current implementation, or should it coexist with the existing code for now?
Thanks for your interest, @Pahari47.
The existing fetch() logic should be replaced with the type-safe method from @gadicc/openfigi.
@dtslvr thanks. I am starting to work
hey @dtslvr i have already started working on this, do i give it a shot or leave it up to pahari?
@yashranaway hey bro! i actually start working on and on the middle way. also read all the stuff. can please let me do it
@dtslvr hey I did PR. kindly check it out
@dtslvr hey I did PR. kindly check it out
Thanks for the update, @Pahari47. I will begin the detailed review once the build passes successfully.
i would like to work on this , please assign me this issue .