Yaron Kaikov

Results 112 comments of Yaron Kaikov
trafficstars

> @yaronkaikov > > This doesn't get a back port PR ? It did with https://github.com/scylladb/scylladb/pull/18652, but AFAIK we shouldn't backport the submodule. @denesb is that right? we should probably...

@denesb I have verified this change on a private repo, and it worked as expected. Can we also verify this on an actual PR in Scylla?

@denesb There is another solution instead of the PR (I just though about it). We have today an automated process in which we are adding a `promoted-to-master` label when the...

> > @denesb There is another solution instead of the PR (I just though about it). We have today an automated process in which we are adding a `promoted-to-master` label...

> > After doing the `git commit amend` we also rebase and push the same commit to the PR. This is what we don't have today. > > How will...

v2: - added remote URL for push command - after update move back to next branch

v2: - simplify the solution using `git notes` to add reference of pull request so it will not update the commit hash - PR description was updated

> > After doing the `git commit amend` we also rebase and push the same commit to the PR. This is what we don't have today. > > I still...

@nyh I will schedule a meeting on Sunday so we can talk about it. I think it will be much more affective

@denesb @nyh Just an update on this one. The guys from Mergify found a bug related to pointing in the PR body to the wrong commit SHA. They are working...