Yardena Cohen

Results 7 comments of Yardena Cohen

I'd call it constructive criticism if there really were a bunch of poorly named commits like that, but ... there... aren't? o.0

Thank you for the background info. Looks like you've been working on this for a while, and I should have done more research before opening a new issue. Sorry about...

I really appreciate this proposal. Closing the metadata leaks, while difficult, would give rclone an order of magnitude more use cases and greatly increase its relevance as a tool for...

Is this version check even still necessary? 2.3.0 and 2.4.0 are both over 12 years old. Checking against both the old and new version schemes would lead to some unwieldy...

Current check happens at https://github.com/OpenLightingProject/ola/blob/master/config/ola.m4#L50 and is called from https://github.com/OpenLightingProject/ola/blob/master/configure.ac#L851 - as you can see, the current code assumes a three-part version, while newer protoc returns a two-part one.

+1 please. This is preventing signal-cli (see https://github.com/AsamK/signal-cli/issues/79) and weechat-signal (https://github.com/thefinn93/signal-weechat/issues/12) from working behind a proxy.

FWIW, thank you very much for all your hard work, and for pushing that 5.16 port. It's much appreciated!