Yanwei Guo

Results 17 comments of Yanwei Guo

I ran the tests hundreds times with my own cluster and could only reproduce the timeout error once. I guess I have to send out a PR to run the...

I don't have much knowledge about this. Conversion request count? Success rate?

> @yanweiguo it seems like underlying grpc is not able to establish connection with the server. There could be number of reasons why it cannot establish the connection. But I...

> It would also be good to include the liveness_probe. :) Changed the title :)

I don't think the failed test is relative to my changes.

For the failed [run](https://00f74ba44b2ee6b8ad02640cfa2371ad1ee272fae8-apidata.googleusercontent.com/download/storage/v1/b/ci-vcr-logs/o/beta%2Frefs%2Fheads%2Fauto-pr-6532%2Fartifacts%2F2fadd96e-fb38-4649-939a-74f5e27852b7%2Fbuild-log%2Frecording_build%2FTestAccCloudRunService_cloudRunServiceProbesExample_recording_test.log?jk=AFshE3UDAv3ALaTAwgccztqTB2TtUPoguUXBfhVoEyGJ-iNMXAPE_e29od2AfPMbGPCeTZrkrMiCtO_0XNR9tnPmACMAKoUpKHKQvXfnv4HESPpKHgjtimHKaQJz4dLxTRKdOl9lpufWVib0yWQj93Pkg67h69eRNesldyOAxu4TvSJ_GN4yrwa8kiCcXSlN5CZurkzWm8j9-gBIXKH3DMnuM23gm5a3a_XthloMXbsvsC9WBe6NYWOF0WvqcHnSUt_IHmBv8MXSdpD8iFJOevkfkJ1UOHr9YcsNZftDXeqrbDHRks9MtRw3QF4A-qj0VtVSGVF1PVsB9922naDdlX-BHZjCzu_FmNy0EQIcorxC0wsNB2JTMlGW8eiQy6re9MXTxGDvzB4x9sKurXGIZfsLmwv5EC0xVB1sqyICsWn3rJ2xpkBdOwTpgPIeJNhjb1EKJ0hyM9sSRTdVhdbNPPncAIIzNyujFSYb7o38xXxkdTk-ZX_lqtvvzwlIhM4rojNzM34hxSPTTCP1R4K3L-1nn7OknfQE7mqv0MvC2k_rmiZQU3lktlF-hGbL0jrppVFi5-t3DWIfDYbwvGrHnh3G0r6PJAXRSh2hTphCHftSQuSon0ivyr-z-j7eKi3rucqk_pFLwpUaiUs9-2a6eHEMGNik2fIVz9tCAZ-Jm0-G1L8iFD5ogaEunAp93PYth0aIbzuXWIeI4mmTg2jDq8bgxPWp14iNhqK-z1LWscQNk9fYuDt6WlPYO8qokO6PT3FhaLZQE9dLW9_eUnuFAHAVmV1zlkkZxBg9yZ_quVClWzG0hZ35sZEeqDG3XrxB6XzZ30uIaAHptwWmbW4MBBNJQLX7rq7gTXpD2croHYo2iwaA3y-n7CZmerwmG-8r0EAyjkafCS5b84JZLepCPHiV1oUvbEQtR6NgKdDWb8hHbDXzjVUnXNG7CT_FFkim5sBQaVE8P-v2IuOBC9Nhnmf2Cg1BU7RUG2Xgwip-2dsZ0bnAsmRMiFwg3N8W8KZ4RLdunfZ83PcC6vhehksK8TCEtcgvq50QIoAd90HHil5wR7peQliTfZ6P9JcpmN569oGKH4Ar3T-0R1-XICH4lDyh_R5vHn-2KAB5UOymPdGaVLkCvzmQGCdvCkCRICNnJT4BghybhB3QCue846OxVrSgrHkI-TKRtsKfEHjzVHJcUcrn6Y-E35sjkcPwpV9i-9rzRcKmweoBkIgSbXg&isca=1) of TestAccCloudRunService_cloudRunServiceProbesExample, it is expected that `run.googleapis.com/ingress` is added by the API. I'm not sure why other examples tests succeeded. Shall I update `cloudRunGoogleProvidedAnnotations` to make...

> What do you think about including the liveness_probe in this PR as suggested in the related opened issue? Talked to the reviewer. Liveness probe is preferred to be added...

Per offline discussion, `path = ""` can be treated invalided in terraform (not in API). I added a comment for that. I have changed the tests to cover the following...

> I agree for the ways to go at this for Category A and B. > > As for Category C: Are K8s Events not sufficient for this currently? There...

> Not sure if this is the correct place to report bugs or if I should open a new issue instead. I noticed that `startup_probe` is not removed (properly) once...