Ilya Yanok

Results 72 comments of Ilya Yanok

Yes, with this change we will only need dummies for nice mocks, not for stubbing.

On the bad side, to the best of my knowledge there is no way to make `Matcher` also accept `int`s in Dart. So we would either have to change all...

@frederikstonge I don't quite follow your comments, are you commenting on the right bug?

Meanwhile, adding one more pro for the change of the API: * We could probably get rid of internal state (and problems with messing it, see https://github.com/dart-lang/mockito/issues/551): currently matchers could...

> On the bad side, to the best of my knowledge there is no way to make `Matcher` also accept `int`s in Dart. Thinking more about this, I don't think...

> Can the migration to the new syntax be done incrementally? (i.e. how will google3 be migrated?) Could introduce the new `when` API as something like `when2` temporarily. I think...

> Can I ask is there a task to update for the `sealed class` to work? You have to be more precise. Mocking sealed classes won't work and that is...

Please create a sample (preferably minimal) project that makes it possible to reproduce the problem. I don't use freezed myself.

Yes, this is an ordering issue: without `json_serializable` `mockBuilder` runs before `freezed`. `json_serializable` helps because `freezed` explicitly requests running before `json_serializable` https://github.com/rrousselGit/freezed/blob/7e478b841f247b8fb0a95722a88392950df22489/packages/freezed/build.yaml#L25 I don't know though, what makes `mockBuilder` run...

Yep, it seems we don't override getters with non-nullable return type, but we have to. Thanks for reporting. I plan to re-work the codegen for Dart3 support significantly, I think...