Ilya Yanok comments

Results 72 comments of


                                            Ilya Yanok

Unexpected "reveals" for non-aliases

Regarding `CMD_EXPANDED=$3`, from zsh doc (http://zsh.sourceforge.net/Doc/Release/Functions.html): > The actual command that will be executed (including expanded aliases) is passed in two different forms: the second argument is a single-line, size-limited...

Paragraph on capture-avoiding substitution (lambda calculus chapter) is confusing

Not really. I only fixed the typo in the substitution definition.

Provide explicit access to the default values of parameters

This would help Mockito to get rid of the need of reviving default values too. Right now we have a problem, if a default value contains a private name. OTOH,...

Provide explicit access to the default values of parameters

Yeah, I know about this trick (and even considered applying it in mockito), that's why I wrote "not supposed" instead of "not allowed" :) It is still behind having to...

Provide explicit access to the default values of parameters

> @iinozemtsev what does mockito actually use the default value for? Does it forward it on to some other method or is it actually capturing the value? We want to...

Check return type of error handler passed to `Future.then`, like we already do for `Future.catchError`

cc @srawlins

Check return type of error handler passed to `Future.then`, like we already do for `Future.catchError`

> Ugh, yeah this is annoying. We could punt on it and leave a TODO. Since already the story is that we don't report enough things; nothing wrong with incrementally...

Check return type of error handler passed to `Future.then`, like we already do for `Future.catchError`

@lrhn Yep, we want to check the static type of the handler, and as part of it we want to check it returns `FutureOr`. I just thought I found two...

[prefer_collection_literals] false positives (local variable assignment/`??` operator/...)

Found another weird case: ```dart class D { LinkedHashMap? m; } void g(D d, LinkedHashMap? hm) { d.m = LinkedHashMap() ; // OK } ``` but ```dart void g(D d,...

[prefer_collection_literals] false positives (local variable assignment/`??` operator/...)

In general, I think this lint should be conservative and only suggest to change to a literal if we 100% sure it will fit (e.g. there is a context type...