Felix Ye

Results 6 comments of Felix Ye

Reference to a related PR: https://github.com/python/cpython/pull/28178

Completed. Any comments or suggestions would be greatly appreciated.

Should I change the definition of macro `RANGE_ERROR` and function `_range_error` in `Modules/_struct.c`? Some arguments of `RANGE_ERROR` are not used. `_range_error` cannot handle `long long` and `unsigned long long`. I...

Thank you for your reviews, @kumaraditya303 @mdickinson. I have one more question. Should I remove parameters `x` and `mask` from macro `RANGE_ERROR` in the previous commit [61c016b](https://github.com/python/cpython/pull/98252/commits/61c016be078524ccc08a3955d6aa48f7a23588d1) `Modules/_struct.c` line 278?...

I have made the requested changes; please review again