Yaniv Efraim

Results 10 comments of Yaniv Efraim

I still get errors when trying to add uncomment `mount` test. I updated jest-cli to version 17.0.0 + I changed to `jest.unmock('../Foo');` I get the following error: > src/**tests**/Foo-test.js >...

Huge thanks!!! You solved me a huge bug (after sharing the window won't close until killing the app!!!). Thanks!!!

@Luismahou I tried to solved this issue by changing this line: destContents = destContents.replace(new RegExp(utils.preg_quote(value[0])+"(\?[0-9a-z]+)?", "g"), value[1]); to become: destContents = destContents.replace(new RegExp("(?:([\"\'\/]))" + utils.preg_quote(value[0])+"(\?[0-9a-z]+)?", "g"), value[1]); This solved the...

Sounds cool. Are those patterns always relevant?

OK, I'm with you on this (:

I use "given, when, then", not sure what is better...

I am on it, hope to send a pull request by tomorrow...

https://github.com/wix/eyes.it/commit/9fae774dd02e8d780e60ca6d732d57171f11acae#commitcomment-28835594

Instead of adding support for mocha here, I would recommend moving to something like [this](https://github.com/wix-incubator/match-screenshot) (develop the same for Protractor - using eyes protractor api under the hood)