Yan

Connection error event never fired if Reader initialised with `lookupdHTTPAddresses`

3

Hi, If I initialise Reader with `lookupdHTTPAddresses` variable set to garbage ``` const reader = new nsq.Reader('test', 'test2', { lookupdHTTPAddresses: 'garbage:9999', }); const handler = () => { console.log('!!!handler fired!!');...

Add 4th argument support for 4-way git merge

2

According to this comment here http://blog.wuwon.id.au/2010/09/painless-merge-conflict-resolution-in.html ``` Meld has hidden 3-way merge feature activated by passing the 4th parameter: [merge] tool = mymeld conflictstyle = diff3 [mergetool "mymeld"] cmd =...

Fix write-single-coil.ts incorrect processing of true value #338

2

Fix for the #338 The WriteSingleCoilResponseBody constructor declares that it can handle `boolen` but it can not do that. So I have addled boolean handling into the function. Manually tested...

CRC calculation error for WriteSingleCoil response

1

## What is the problem * `client.writeSingleCoil(6, true)` response is CRC-ed incorrectly if the values is set to true * `client.writeSingleCoil(6, false)` response is CRC-ed correctly The problem above is...