Antonio Yang
Antonio Yang
> based on your last comment in the previous PR: > > > Just hard to find another crate with the same function but using syn2. This is the same...
> > And the default ssh key will be ~/.ssh/id_rsa or ~/.ssh/id_ed25519, which will depend on the way the user generates his key. I think for the first iteration it...
git commit use following option to sign a commit with GPG `git-commit -S[], --gpg-sign[=]` And the ssh sign is using ssh secret key but the header still `gpgsig`, and GITHUB...
> as far as i can see it has to be configured like this: https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key#telling-git-about-your-ssh-key > > so we can just use these git configs to know what signing key...
By the way, the way to set git config with `gpg.format ssh` will not work as what you see on the web page. ``` └─[$] git commit -m 'test ssh...
You may wonder why we need `Clone` trait on `CliArgs` Because clippy will cry on passing too many fields of `CliArgs` in `run_app` function. https://github.com/extrawurst/gitui/actions/runs/7888377158/job/21525757826
@extrawurst It now is ready to review
> > You can see the config is a pub key for verification not a secret key for a sign. > > this is exactly what every source I find...
Hi @extrawurst I believe this is good to go.
Hi @extrawurst The master is merged into this branch, so the sign can be retained. :smile: