Yair Gottdenker

There are indications that jemalloc is faster and uses less memory than mimalloc. See for example: https://github.com/rust-lang/rust-analyzer/issues/1441#issuecomment-2016419122 The used jemalloc version is quite old. The main challenge is related to...

@WM0323 , I'm curious to get your thoughts on what maybe some the reasons that the rust community reached the opposite conclusion - jemalloc is faster and consumes less memory...

Some thoughts around improving the benchmark signal: 1. Consider incorporating SET commands with variant payload size. 2. The benchmark should exercise `free` more often. Consider issuing a mix of DEL...

Planning to add unit tests soon. Publishing early to start the discussion rolling.

@zuiderkwast , @ranshid , happy discuss further with you! It would be valuable for ValkeySearch 1.0 to have such interface in 8.1, after all there is no second chance to...

> Some initial highlevel comments. > > I think the main issue I have is that this new API implementation has some unclear limitations. For example it can only support...

> Not a full review. Just a few thoughts. > > * I acknowledge the need to share strings between module and core. > * I think this shared string...

> * I think this shared string type should be called `ValkeyModuleSharedString`. There is nothing SDS-specific in the API so the term SDS has no meaning in the module perspective....

Resurrecting this PR. To avoid missing the 9.0 release window, we need to resume work on it ASAP. @zuiderkwast, @ranshid, the key question is whether you have any reservations about,...

> I have concerns about the added complexity. This needs a lot of reviewing, looking at the bigger picture and refactoring to avoid adding technical dept. That's a great concern...