Michael Yagudaev
Michael Yagudaev
Having the same issue. It is tied to: https://github.com/webpack/webpack/issues/708. For us our CI server fails on trying to load phantomjs but still shows the tests pass. See https://github.com/karma-runner/karma-phantomjs-launcher/issues/120 Turns out...
@Izhaki I've actually hit the same issue without even using this library. As you mentioned, anytime you use a HOC on a next.js page it doesn't work. Here is a...
Found this error to also happen if you end up using Karma directly from github source. Turns out there is a difference between the Karma code on npm and the...
> In retrospect, it might be better to add it to DefinitelyTyped—that way users don't have to generate any code to stay up-to-date with the gem. That leads to a...
I like the idea of the NPM module to encapsulate all the generated commands. Great discussion guys. Sorry for being late to the party, been busy trying to launch our...
Ok taking a quick look at the code I see where the problem is: https://github.com/shakacode/cypress-on-rails/blob/master/lib/cypress_dev/command_executor.rb#L9 ```ruby class CommandExecutor def self.load(file,command_options = nil) load_cypress_helper file_data = File.read(file) eval file_data rescue =>...
Looking at it even further and discussing with colleagues really quickly. ```javascript Cypress.Commands.add('appCommands', function (body) { cy.request({ method: 'POST', url: "/__cypress__/command", body: JSON.stringify(body), log: true, failOnStatusCode: true }) }); ```...
@grantspeelman thanks for the quick and thoughtful response and building the gem :). > Doing eval's like this was supported in the first versions of cypress-on-rails, so i wanted to...
@grantspeelman can you add a license to the project? #12 Pretty please? :) I would like to try and use this gem, fork it and try spiking on some of...
I do think it is worth it for consistency. The new release with a description about the rename will tell people it has been renamed and avoid confusion. Overtime it...