Amos Jeffries

Results 156 comments of Amos Jeffries

> I hope we do not need to work on this PR until the partially overlapping #832 and #835 are in. The former adds (partial) support for PROXY protocol on...

NP: re-wrapped text without changes to fix the failed-description flag.

Putting aside my dislike of the extra CPU cycles this API design creates from all the de-ref/re-ref taking I can accept your changes. @rousskov This last push is simply a...

FTR: after seeing what these caches store I am not sure we need them at all. It may be better to cache helper lookup results and have the proxy_auth use...

@rousskov, I am bumping this back to reviewer for a re-check. Since the name type change is being done by PR #712 there appear to be no outstanding issues blocking...

@rousskov, are we okay on the updateContextCiphers() situation so this can be merged? or you strongly wanting all the callers to have try-catch added for Must() ?

Last few review comments fixed, or out of scope with explanation why.