squid icon indicating copy to clipboard operation
squid copied to clipboard

Published 20 hours ago • verified publisher icon squid-cache

TLS: move CertificateProperties to libsecurity

Open yadij opened this issue 6 years ago • 3 comments

These pieces are required by certificate generation / mimic.

Convert the enum type strings to auto-generated arrays instead of requiring manual work to keep in-sync.

yadij avatar Feb 01 '18 11:02 yadij

@rousskov, are we okay on the updateContextCiphers() situation so this can be merged? or you strongly wanting all the callers to have try-catch added for Must() ?

yadij avatar Feb 16 '18 22:02 yadij

I went through all https://github.com/squid-cache/squid/pull/139#pullrequestreview-98401617 change requests and resolved all those that I consider addressed. A few still need to be addressed, so I am bouncing this PR off to your side again.

rousskov avatar Nov 13 '18 18:11 rousskov

Last few review comments fixed, or out of scope with explanation why.

yadij avatar Jun 22 '20 16:06 yadij