Isaac Boehman

Results 15 comments of Isaac Boehman

This is exactly what I've wanted from PRT. Definitely want to keep an eye on this PR.

Thanks for taking a look, appreciate it. I just updated the gist, it's slightly more complicated now but now you can refer to columns by their title instead of their...

@rnpridgeon can do, I'll handle those changes tomorrow morning when I get into the office.

I think CI failure is unrelated to my changes, seems the path to `golint` needs fixing. ``` package github.com/golang/lint/golint: code in directory /Users/travis/gopath/src/github.com/golang/lint/golint expects import "golang.org/x/lint/golint" ``` Yup, needed fixing...

hmm, the new CI failure doesn't make sense to me: ``` $ go get -u golang.org/x/lint/golint # golang.org/x/tools/go/internal/gcimporter ../../../golang.org/x/tools/go/internal/gcimporter/bexport.go:212: obj.IsAlias undefined (type *types.TypeName has no field or method IsAlias) ```

Okay, now we're getting somewhere. According to https://github.com/golang/tools/commit/a53bc13a6341e9847bbcf8c0a0691e60e18a87c0 (which landed just two days ago) Support for GoLang versions < 1.10 in `gcimporter` was removed. So basically, any builds for go...

@rnpridgeon I removed `Events()` and `QueryWatermarkOffsets()` from `Handle` since the new Admin API client doesn't implement either but uses the `Handle` interface. ETA: Also I removed the unsupported go versions...

@rnpridgeon can I get another review?

Please let me know if there's anything I can do to assist.

@rileykarson I don't have permission to view the details for the `terraform-provider-google-lint` and `terraform-provider-google-test` checks to see why they failed -- is there anything I need to address for those?...