y-yagi

Results 19 comments of y-yagi

We recently encount same error but can't reproduce manually... @lnsight Can you share your patch?

`ssh/terminal` is just the wrapper of `x/term`. https://github.com/golang/crypto/blob/master/ssh/terminal/terminal.go So the code that was originally working keeps working and doesn't break compatibility with Go 1.13 I think(I could confirm that the...

Failed test is unrelated with this change. That test will fix by #912.

Rebased with master and now CI passes.

It seems this is intended. The `instant` has been renamed into `auto`. So you need to change `instant` into `auto`. Ref: https://github.com/microsoft/TypeScript-DOM-lib-generator/commit/fe01c9a6d6afde86bd15f2588dc9360416a2beb4#r31507840

Thanks for the reply! This is the only callback that we need.

@ryanfaerman Are you still interested in this PR? I encountered this issue too, and want to fix.