Sourav Moitra
Sourav Moitra
@kwilczynski @PannagaRao @saschagrunert I would like to work on this.
@kwilczynski @saschagrunert @haircommander I believe we can break down the proposed changes into three separate tasks that can be implemented independently. Here's a breakdown of each task: 1. Refactoring Pod...
> > Enforcing Code Formatting with Revive: Instead of golangci-lint, we propose trying out the revive linter. > > I don't think we need that, the rest looks sane to...
@saschagrunert @kwilczynski @haircommander I need some clarification *Current* We have `sandbox` struct which is internally used and `Sandbox` is the interface. To instantiate a sandbox object we use ```go sbox...
@haircommander Yes it make sense thank you for the clarification. Let me try to summarize as Story **Summary**: Currently, sandbox creation involves a factory and translation object. This story proposes...
@haircommander I have gone through the code and trying to ideate a solution. So this is in a way thinking out loud. `server\sandbox_run_linux:runPodSandbox` creates the sandboxFactory, CNIPluginwatcher, podContainer, container and...
@haircommander If we use a singleton pattern for SandboxBuilder, we will only be able to create one Sandbox at a time. Therefore, this is not an ideal solution, and we...
> > Call to the sbuilder.GetSandbox resets the Sandbox. > I think we don't need reset. The whole process will be similar to what we do now, but instead, we...