Daniel Frederico Lins Leite comments

Results 101 comments of


                                            Daniel Frederico Lins Leite

perf(rome_js_semantic): POC: reduce semantic model writes

> Only store declaration reads/writes once instead of twice I thought this initially. Not sure if this makes a huge difference. Will test here. The picking of the nodes I...

perf(rome_js_semantic): POC: reduce semantic model writes

I incorporated these suggestions at https://github.com/rome/tools/pull/3825. I think we can close this PR.

🐛 Rome VSCode extension crashes for closure function passing itself as an argument

I will assign this to myself.

📎 Suggest destructuring fix for `noDelete` rule

Why ```{ deletedProperty, object } = object``` would be better than ```delete object.deletedProperty```? Honestly, being a non-Js developer, I find the later easy to grasp. EDIT: I think your past...

feat(rome_cli): cli exit as error when no files are found

@leops I changed the semantic of the processed variable. Are you ok with this change?

feat(rome_cli): cli exit as error when no files are found

> Could you please add a new test case so we can snapshot the error message? Done.

🐛 LSP/parser get in a buggy state when encountering some strings

If there is a strange unicode char in the middle, something may be sanitizing it. Can you open the original string with a hex editor and paste the bytes here?...

🐛 LSP/parser get in a buggy state when encountering some strings

@leops wanna take over this then? Or want to leave with me?

🐛 noUnusedVariables --write applies the underscore fix instead of removal for imports

Ideally yes, we should remove. Actually, the first version of the rule default suggestion was to remove unused bindings. The problem is that I am not entirely sure this is...

Feature/semantic model improvements

!bench_analyzer