Daniel Frederico Lins Leite
Daniel Frederico Lins Leite
"Goto definition" will only be relevant when we run and the only LSP (non vscode).
We already have a code that checks this: crates\rome_js_parser\src\syntax\class.rs:944 ```rust else if modifiers.has(ModifierKind::Declare) || p.state.in_ambient_context() { // test_err ts ts_property_initializer_ambient_context // declare class A { prop = "test" } //...
There are a couple of other changes I want to move from the parser to linters. I will create a small list and we can decide if makes sense or...
> @xunilrj would you mind a give a second view and merge if you think it's fine? Done.
More problems found in the wild: - [ ] Optional binding on .d.ts - [ ] Export anonymous function in .d.ts - [ ] Initializers in ambient contexts - [x]...
Should we limit this to only one read reference? Because if the "initializer" has side effects, we will be changing the code semantic.
> Have you consider implementing such methods on `JsAnyExpression` and all expression types? I can see this to be useful for many other analysis too Yes. But I don´t consider...
More details about https://github.com/rome/tools/pull/3355 Checks the dependencies array of React Hooks contains all referenced bindings Example error: function Component({ prop }) { useEffect(() => { prop(); }, []); } -...
Should this be a rule on itself? "Spread should be at the beginning on JSX bla bla bla".
I will get this because it will be useful for my rule: https://github.com/rome/tools/pull/3355