Sven Sauleau

icon indicating a website link https://sauleau.com icon indicating an email [email protected]

icon location London, UK icon location https://twitter.com/svensauleau

Results 316 comments of Sven Sauleau

wasm-parser/wasm-gen or wast-parser/wast-printer incorrectly handle "end" instruction in globals initialization

Thanks for the the detailed report. At first glace I think the wast printer needs to changed to not print the end instruction where's not legal.

wasm-parser/wasm-gen or wast-parser/wast-printer incorrectly handle "end" instruction in globals initialization

It would be nice if you can fix that inconsistency as well, but please in a sperated PR, that's going to be easier to review.

`local.get` or `get_local`

Make sense. Please feel free to submit a change

WASM code gen

I didn't know about that, it's looking good. All that stuff in quite new, having a custom WAST parser allows more flexibility. No formal AST is available, we almost have...

Implement producer section

Missing the wasm-edit API for https://github.com/webpack/webpack/issues/8429.

globals should not support multiple initialisation instructions

I added a note here about that https://github.com/xtuc/js-webassembly-interpreter/blob/431caff0cb1debecd7c3b864103f78d3debc1ac6/src/interpreter/runtime/values/global.js#L19-L23. Might be worth opening an issue on the spec to clarify this? The test you mentioned is only for parsing, since it's...

globals should not support multiple initialisation instructions

Thanks!

Reactivate block test in wasm-parser

Ok, thanks for the clarification. The name is probably available in WAST as syntactic sugar but not actual semantics. So I guess we should just remove this test?

Pass custom_section testsuite

has been reverted

chore: migrate to use es6 module syntax

This was before refactoring the repo to a monorepo. We need to remove the circular dependencies first (otherwise ESM won't work).