Riccardo Magliocchetti

Results 377 comments of Riccardo Magliocchetti

`` That could be a good chance to run black over the code to avoid getting style fixes in unrelated PRs.

We already bumped black

At least a CHANGELOG entry is required.

Closing as superseded by #2538

@brianwarner I would recommend to run tests locally before asking for a review :sweat_smile:

> Hi @xrmx. What use cases would this update fix? e.g. startup errors, duplicate spans, errored spans bootstrap looks into this field for adding instrumentations based on the installed libraries....

Revamped the PR to teach bootstrap about AND'ed dependencies. The idea here is to use lists instead of strings to express AND'ed dependencies (i.e. when the istrumentation requires more than...

Since we are hooking into transport `perform_request` we can check if one of its kwargs is `otel_span` (https://github.com/elastic/elasticsearch-py/blob/main/elasticsearch/_sync/client/_base.py#L271) and if its `enabled` attribute is True (https://github.com/elastic/elasticsearch-py/blob/main/elasticsearch/_otel.py#L46).

Before fixing this we need to make tests pass with elasticsearch 7 and 8