opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

Update starlette version

Open SwathiEnugula202 opened this issue 1 year ago • 10 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A

Does This PR Require a Core Repo Change?

  • [ ] Yes. - Link to PR:
  • [ ] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [ ] Followed the style guidelines of this project
  • [ ] Changelogs have been updated
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

SwathiEnugula202 avatar Apr 26 '24 02:04 SwathiEnugula202

CLA Not Signed

  • :white_check_mark: login: swathienugula (beb32027f98b8070067e4b2f64efe027191f42a4, 760db1385037eb04a82dcbb26fe40fba8631e616)
  • :x: - login: @SwathiEnugula202 / name: Swathi Enugula . The commit (e451187c0ce9bc46ed72267347d74fdc57e86666) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

/easycla

brianwarner avatar Apr 26 '24 14:04 brianwarner

/easycla

brianwarner avatar Apr 26 '24 15:04 brianwarner

/easycla

brianwarner avatar Apr 26 '24 15:04 brianwarner

Hi @ocelotl, thanks for your help with all of our contributions!

I see this instrumentation is not listed within the component_owners.yml file. Is there someone you'd recommend @SwathiEnugula202 request as a reviewer?

Thanks!

brianwarner avatar May 29 '24 15:05 brianwarner

@brianwarner I would recommend to run tests locally before asking for a review :sweat_smile:

xrmx avatar Jun 13 '24 14:06 xrmx

@SwathiEnugula202 is the author of the PR.

Swathi, could you please verify that the test cases are passing when run locally? Thanks!

brianwarner avatar Jun 13 '24 14:06 brianwarner

@brianwarner the tests passed locally.

SwathiEnugula202 avatar Jun 24 '24 14:06 SwathiEnugula202

Resolved the conflicts

SwathiEnugula202 avatar Jun 28 '24 17:06 SwathiEnugula202

We need CLA to be signed. If you want us to be able to rebase this PR branch on main we need you to authorize maintainers to change this PR.

ocelotl avatar Jul 03 '24 00:07 ocelotl