Vitalik Gordon
Vitalik Gordon
@brianzhou13 Thanks for the PR! However, I just checked with my Chrome (`Version 79.0.3945.130 (Official Build) (64-bit)`), and it behaves just fine with the previous `getSelf` usage. It didn't load...
@oneezy Thanks for the feedback. I'm setting the `currentWindow` back to `true` then (until there is an overwhelming evidence that the `false` setting is better...). And this open issue will...
@smcllns Thank you for your response! I'll reopen the issue for now (let's see if there's more feedback coming), also will try your suggestion soon – there are going to...
@mikob I wonder if we can read `manifest.json` and pull custom options from there instead of passing them down via a function call? I don't know if it's possible, but...
> Why would that be nicer? Because it would maintain the backward compatibility with the current "zero-configuration" version. In the proposed new version users are supposed to explicitly pass the...
Also, putting scripts/plugins options to manifest files is not unusual. For example, it is norm with `package.json` – often toolchain scripts read their (custom) options from there, and it's rather...
Could you also please combine all your PRs into a single one? It would be easier to review and edit it then. They all seem linked and also all of...
Does anyone have any suggestions how to work around this? I don't keep up with the latest news on extensions API changes :(
@AndersDJohnson Thanks for the PR! Sorry for the stupid questions, just don't have the time neither to check if it's working, nor for reviewing the code thoroughly ( In particular,...
@AndersDJohnson Thanks for the explanation. I somehow missed your initial premise that you need to ensure that all those files should actually _exist_ before reloading, and thought that you simply...