xpivarc comments

Results 566 comments of


                                            xpivarc

Tolerate some errors in VM Create()

I think it would make more sense to use auth API to verify your user(SA) can do what you want. The proposed solution affects all the tests which I dislike...

Fix containerdisk unmount logic

/cc @rmohr

Fix containerdisk unmount logic

/cherry-pick release-0.56

cannot ssh to vm when in masquerade mode

:ping_pong: @EdDev

paast, e2e, Skip if featureGate is disabled

/hold @RamLavi This needs rebase.

paast, e2e, Skip if featureGate is disabled

> > /hold @RamLavi This needs rebase. > > Done https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8266/pull-kubevirt-generate/1557694331635109888 You also need to run `make generate`

paast, e2e, Skip if featureGate is disabled

Looks good now. @AlonaKaplan PTAL

paast, e2e, Skip if featureGate is disabled

/hold See @AlonaKaplan comment

pdb: silence 'PodDisruptionBudgetAtLimit' alert for migratable VMIs

/lgtm

Address some parallel testing complications that cause flakes

/cc @rmohr