Andy Zobro
Andy Zobro
Can we get an SVG for this?
I'm still getting used to the concept that "C" will Buy into Cargo. (Always, "Buy" for free from Storage, or Buy from Shop). So, one will have to get used...
:-( I ran the code checker at home before merging and it was totally happy -- bummer.
With respect to performance in the Release build, I have noticed that when buying 50000 javelins into Cargo it can take a little time (
> Code comments generally should be formatted as normal sentences I'm all ears, I added a ton of comments as I am totally new to the codebase and as much...
> Note that I'm not a code reviewer; so this approval doesn't mean as much as the dedicated coders'. I don't know who's who or how I'm supposed to know...
> Our style standards require correct punctuation in code comments, so please do it. 👍 > Also I'm not sure what's the purpose of `static_cast`ing doubles to bools. Well, you're...
I think we're nearing the end of this, or, at least I hope so, but I think this PR should stay open until these have been reviewed and accepted: https://github.com/endless-sky/endless-sky-wiki/pull/74...
> I have to say, I'm rather concerned with the number of buttons in the outfitter; it would be really easy to click the wrong button, and it looks rather...
> I recall a PR somewhere for doing that... https://github.com/endless-sky/endless-sky/pull/10187? Doh! I had no idea. 🙄 Also, i discovered last night that the mobile version uses pop-up menus. > Yeah....