Li Yuxuan comments

Results 13 comments of


                                            Li Yuxuan

feat(slider): add vertical slider support and update docs

Rebased to resolve conflicts

feat(slider): add vertical slider support and update docs

Resolved conflicts & comments. Updated sink to have a better use case of vertical slider like this shown below (maybe like music app equalizer) ![CleanShot 2024-04-15 at 15 43 32@2x](https://github.com/shadcn-ui/ui/assets/44829092/5140caa8-dafb-4633-97a6-08c4ca332071)

feat(slider): add vertical slider support and update docs

Thanks for approval. Anyone knows how to kickstart the workflows? Seems like it still needs authorization to proceed. 🙏🏻

fix(select): select click event passthrough underneath

> why hasn't this been merged already still waiting for two more approval. 🙏🏻🙏🏻

fix(select): select click event passthrough underneath

> Maybe we'll get to celebrate the anniversary of this PR 🥳 5 more months to go 🥲

Not getting the full type when parsing multipart/form-data

I think a better approach would be to use `radix/primitive` exposed `data-orientation` attribute to differentiate the horizontal and vertical case directly using tailwindcss `data-*` modifier. And another small nit is...

Bug(Slider): Slider in vertical orientation does not work

> @xmliszt still no fixes for this? I think @rishabhbizzle has a fix in the PR, but anyway I will also look into this. The PR needs @shadcn team to...

Select issue in mobile mode

Encounter the same issue on my side with ``. I will try to fix this and make a PR!

Select issue in mobile mode

Hi guys, after some investigation and trial and error with my app, I found a temporary workaround. ![image](https://github.com/shadcn-ui/ui/assets/44829092/69119a9e-7d0a-4e7f-86c9-b393ea403f02) In my case, as shown in screenshot above, I have this ``...

Select issue in mobile mode

Submitted a fix to radix-ui team: https://github.com/radix-ui/primitives/pull/2403 Hope it will resolve the issue at its root :)